fix remaining to-dos

data_analysis/02-3_oracle_workflow_test.py

@@ -95,7 +95,6 @@ print("Starting date: ", start_date)
 # %%
 # // ---------- LIVE DATA -----------
 
-# TODO find way to filter more efficiently
 # WF-200: filter for relevant orders with current BEDP set
 # missing: order types which are relevant
 filter_K_rech = (608991, 260202)
@@ -185,7 +184,6 @@ print(stmt.compile(engine))
 
 # %%
 # raw data query
-# TODO look for entries which do not have an associated title number
 
 print("--------------- raw data query --------------")
 t1 = time.perf_counter()
@@ -603,11 +601,6 @@ class PipelineResult:
                 "MANDFUEHR",
             ]
         )
-        # TODO remove
-        # results = results.select(RESULT_COLUMN_ORDER)
-        # print(results)
-        # print("####################")
-        # print(self._results)
 
         self._subtract_data(data)
         self._add_results(results)
@@ -783,7 +776,6 @@ def wf100_petersen(
             filter_number_vm,
         ),
     )
-
     pipe_result.write_results(
         data=res.in_,
         vorlage=False,
@@ -791,9 +783,6 @@ def wf100_petersen(
         freigabe_auto=types.Freigabe.WF_100,
         order_qty_expr=ORDER_QTY_FUNC(empty=True),
     )
-
-    # TODO add check for orders or quantity to transform
-    # TODO show them
     filter_number_vm = pl.col(vm_criterion) > 0
     res_candidates = _apply_several_filters(
         pipe_result.open,
@@ -806,7 +795,7 @@ def wf100_petersen(
     )
     wdb_sub_pipe = PipelineResult(res_candidates.in_)
     wdb_sub_pipe = _wf100_petersen_sub1_wdb(wdb_sub_pipe)
-    assert wdb_sub_pipe.open.height == 0
+    assert wdb_sub_pipe.open.height == 0, "Sub pipe not fully processed"
     pipe_result.merge_pipeline(wdb_sub_pipe)
 
     # // other branch
@@ -973,7 +962,7 @@ def wf200_petersen(
     )
     sub_pipe = PipelineResult(res.in_)
     sub_pipe = _wf200_sub1(sub_pipe)
-    assert sub_pipe.open.height == 0
+    assert sub_pipe.open.height == 0, "Sub pipe not fully processed"
     pipe_result.merge_pipeline(sub_pipe)
 
     return pipe_result