delta-barth/delta-barth-py
1
0
Fork 0
Code Issues 3 Pull Requests Actions Packages Projects 3 Releases 3 Wiki Activity

unnecessary API call #25

New Issue
Closed
opened 2025-04-29 11:58:33 +00:00 by foefl · 3 comments
foefl commented 2025-04-29 11:58:33 +00:00
Owner
Copy Link
  • reported: 29.04.2025
  • method call of forecast pipeline seems to call external API twice instead of once
  • one call with: customer_id = 999999 and starting_date = None
- reported: 29.04.2025 - method call of forecast pipeline seems to call external API twice instead of once - one call with: `customer_id = 999999` and `starting_date = None`
foefl added the
bug
 label 2025-04-29 11:58:33 +00:00
foefl self-assigned this 2025-04-29 11:58:33 +00:00
foefl added this to the bug fixes project 2025-04-29 11:58:33 +00:00
foefl moved this to In Progress in bug fixes on 2025-04-29 12:12:17 +00:00
foefl commented 2025-04-29 12:18:21 +00:00
Author
Owner
Copy Link

included to assert login status, see:

src/delta_barth/session.py Line 308 in daaf48f1db
params: dict[str, int] = {"FirmaId": 999999}

included to assert login status, see: https://git.d-opt.de/delta-barth/delta-barth-py/src/commit/daaf48f1dbcafa683edbda184e0567b9c60bdbc6/src/delta_barth/session.py#L308
foefl commented 2025-04-29 12:38:48 +00:00
Author
Owner
Copy Link

check elimination of assertion for login

  • directly try to obtain data and in case of 401 error try to re-login
  • change signature from assert_login to relogin or just use login method
**check elimination of assertion for login** - directly try to obtain data and in case of 401 error try to re-login - change signature from `assert_login` to `relogin` or just use `login` method
foefl commented 2025-04-30 05:39:33 +00:00
Author
Owner
Copy Link

add max retry parameter to constants

add max retry parameter to constants
foefl added reference login_assertion 2025-04-30 05:41:02 +00:00
foefl closed this issue 2025-04-30 06:46:54 +00:00
foefl moved this to Done in bug fixes on 2025-04-30 06:47:05 +00:00
Sign in to join this conversation.
login_assertion
Branches Tags
Labels
Clear labels
bug
Something is not working
duplicate
This issue or pull request already exists
enhancement
New feature
help wanted
Need some help
invalid
Something is wrong
question
More information is needed
wontfix
This won't be fixed
No Label
bug
Milestone
No items
No Milestone
Projects
Clear projects
No project bug fixes
Assignees
Clear assignees
foefl frasu
No Assignees foefl
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: delta-barth/delta-barth-py#25
No description provided.
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?